skip failing api calls #7059
skip failing api calls #7059
Conversation
There was a problem hiding this comment.
Thanks for taking a look at this! Looks like this PR hit #4949
We talked about not bailing on failures on last week's huddle, but I'm unsure if there was a consensus on which services we want to warn about only? ClickHouse db initialization seems like a good candidate for not bailing out due to a failure, so I'm all in for this change. Just want to make sure we have some sort of follow up issue or something about which errors we want to skip and which ones should stop the process entirely.
| if let Err(e) = client.init_db().await { | ||
| warn!( | ||
| log, | ||
| "failed to initialize single-node clickhouse database: {e}" |
There was a problem hiding this comment.
Are we going to want to do the same for keepers and replicated servers?
There was a problem hiding this comment.
Yup! I'm going to do this very shortly.
@davepacheco opened #6999 last week to cover this. It doesn't have any specific service call outs yet though. |
There was a problem hiding this comment.
@davepacheco opened #6999 last week to cover this. It doesn't have any specific service call outs yet though.
Ha! Looks like I missed that issue somehow. Looks good to me then!
You are very welcome. Feel free to merge this into your branch or copy or whatever you desire. |
No description provided.